Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the npm_and_yarn group across 1 directory with 3 updates #750

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Bump the npm_and_yarn group across 1 directory with 3 updates #750

merged 2 commits into from
Mar 20, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 17, 2024

Bumps the npm_and_yarn group with 3 updates in the / directory: follow-redirects, taffydb and jsdoc.

Updates follow-redirects from 1.15.5 to 1.15.6

Commits

Removes taffydb

Updates jsdoc from 3.6.11 to 4.0.2

Changelog

Sourced from jsdoc's changelog.

4.0.2 (February 2023)

Updates the Babel parser, and enables additional Babel plugins for ECMAScript proposals.

4.0.1 (February 2023)

If an inline link tag uses a pipe delimiter, and there are spaces around the pipe delimiter, then the HTML link no longer contains %20 at the end; also, the link text no longer contains extra spaces. For example, {@link https://example.com | link text} is now rendered as <a href="https://example.com/">link text</a> rather than <a href="https://example.com/%20"> link text</a>.

4.0.0 (November 2022)

Commits
  • 0b6193f 4.0.2
  • 9d88548 deps: update Babel; enable current Babel plugins in parser
  • c2dd210 4.0.1
  • 3d90c8a fix: in inline links, strip spaces around pipe character
  • 37fc8cd chore: tell Prettier not to format files
  • a5e4688 chore(deps): update deps
  • 0842185 4.0.0
  • b018408 chore!: replace taffydb package with @​jsdoc/salty
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot
Bump the npm_and_yarn group across 1 directory with 3 updates
14abf2e 
Bumps the npm_and_yarn group with 3 updates in the / directory: [follow-redirects](https://github.com/follow-redirects/follow-redirects), [taffydb](https://github.com/typicaljoe/taffydb) and [jsdoc](https://github.com/jsdoc/jsdoc).


Updates `follow-redirects` from 1.15.5 to 1.15.6
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6)

Removes `taffydb`

Updates `jsdoc` from 3.6.11 to 4.0.2
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/4.0.2/CHANGES.md)
- [Commits](jsdoc/jsdoc@3.6.11...4.0.2)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
  dependency-group: npm_and_yarn-security-group
- dependency-name: taffydb
  dependency-type: indirect
  dependency-group: npm_and_yarn-security-group
- dependency-name: jsdoc
  dependency-type: direct:development
  dependency-group: npm_and_yarn-security-group
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the javascript Pull requests that update Javascript code label Mar 17, 2024
@dependabot dependabot bot requested a review from dkotter as a code owner March 17, 2024 00:41
@dependabot dependabot bot added the type:dependency An issue with a separate library that this project relies upon. label Mar 17, 2024
@dependabot dependabot bot requested review from jeffpaul and a team as code owners March 17, 2024 00:41
@jeffpaul jeffpaul added this to the 3.1.0 milestone Mar 18, 2024
@jeffpaul jeffpaul removed request for a team, dkotter and jeffpaul March 18, 2024 17:41
@dkotter
Copy link
Collaborator

dkotter commented Mar 19, 2024

Same issue as mentioned here: #737 (comment)

@dkotter dkotter mentioned this pull request Mar 19, 2024
Closed
@dkotter dkotter modified the milestones: 3.1.0, Future Release Mar 19, 2024
@faisal-alvi
Copy link
Member

@dkotter I tried to build the docs and got the error FATAL: Unable to load template: Cannot find module 'taffydb' So I added taffydb as a dev dependency and it worked.

image

@faisal-alvi faisal-alvi mentioned this pull request Mar 20, 2024
Closed
@github-actions github-actions bot added the needs:code-review This requires code review. label Mar 20, 2024
@dkotter dkotter modified the milestones: Future Release, 3.1.0 Mar 20, 2024
@dkotter
Copy link
Collaborator

dkotter commented Mar 20, 2024

@dkotter I tried to build the docs and got the error FATAL: Unable to load template: Cannot find module 'taffydb' So I added taffydb as a dev dependency and it worked.

Thanks for checking on this. I tested myself and this does fix the problem and the built docs seem to match. The only issue is that taffydb has a security issue which is one of the things this PR is attempting to fix.

But that said, there are a few other security vulnerabilities that this PR fixes so I'm okay with adding taffydb back to fix those. I do think we'll still want to look at other options to build our hook docs so we can fully resolve these issues.

@dkotter dkotter merged commit 8051ec3 into develop Mar 20, 2024
13 checks passed
@dkotter dkotter deleted the dependabot/npm_and_yarn/npm_and_yarn-security-group-2d05be66f8 branch March 20, 2024 13:26
@dkotter dkotter removed the BLOCKED label Mar 20, 2024
@faisal-alvi faisal-alvi mentioned this pull request Mar 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code needs:code-review This requires code review. type:dependency An issue with a separate library that this project relies upon.
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dkotter @faisal-alvi @jeffpaul